Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix[codegen]: fix raw_log() when topics are non-literals #3977

Merged
merged 7 commits into from
May 13, 2024

Conversation

cyberthirst
Copy link
Collaborator

@cyberthirst cyberthirst commented Apr 26, 2024

What I did

How I did it

  • call unwrap on the topics

How to verify it

  • added new tests

Commit message

this commit fixes codegen for the `raw_log()` builtin when the topics
are non-literals. `unwrap_location()` was not being called, so when the
topic expression is not a literal, the pointer to the variable was being
returned instead of the value of the variable.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@cyberthirst
Copy link
Collaborator Author

is any caching of topics needed?

@charles-cooper charles-cooper added this to the v0.4.0 milestone May 7, 2024
@cyberthirst cyberthirst marked this pull request as ready for review May 12, 2024 13:44
@charles-cooper charles-cooper changed the title fix[codegen]: fix incorrect topic logging in raw_log for non-literal expressions fix[codegen]: fix raw_log() when topics are non-literals May 13, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) May 13, 2024 14:48
@charles-cooper charles-cooper merged commit 120b7d5 into vyperlang:master May 13, 2024
152 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants