Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix[venom]: fix eval of exp in sccp #4009

Merged
merged 4 commits into from
May 8, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented May 8, 2024

What I did

How I did it

How to verify it

Commit message

fix `exp` evaluation in sccp. the current implementation is incorrect,
which was found by enabling the `venom + -opt-none` pipeline in the CI.
`evm_pow` is correct, as it preserves the correct edge cases when
base/exponent are 0 or 1 (all combinations).

this commit also enables the `venom + -opt-none` and
`venom + -opt-codesize` jobs in the CI, ensuring higher coverage of the
venom pipeline going forward.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper requested a review from harkal May 8, 2024 15:41
@charles-cooper charles-cooper merged commit f213655 into vyperlang:master May 8, 2024
152 checks passed
@charles-cooper charles-cooper deleted the fix/sccp-exp-eval branch May 8, 2024 16:09
# (slightly different behavior depending if venom pipeline is enabled):
if not experimental_codegen:
expected_jumps = 3
else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double negatives are unnecessarily hard to read

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants