-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat[tool]: add all imported modules to -f annotated_ast
output
#4209
feat[tool]: add all imported modules to -f annotated_ast
output
#4209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4209 +/- ##
==========================================
- Coverage 91.35% 88.82% -2.53%
==========================================
Files 110 110
Lines 15789 15810 +21
Branches 2674 2678 +4
==========================================
- Hits 14424 14044 -380
- Misses 931 1256 +325
- Partials 434 510 +76 ☔ View full report in Codecov by Sentry. |
vyper/compiler/output.py
Outdated
# come from multiple InputBundles (particularly builtin interfaces), | ||
# so source_id is not guaranteed to be unique. | ||
if ast.resolved_path in unique_modules: | ||
# sanity check -- object equality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
operator checks for identity, not equality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, that's what I meant by object ("pointer") equality
can we add a test for recursive imports? |
would you mind helping contribute these? |
with #4229 we could add the imports also to edit: fixed link |
yes, we could |
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture