fix[tool]: fix classification of AST nodes #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix classification of AnnAssign nodes
charles-cooper
changed the title
|
how was this discovered - was it motivated by some issue? also, did you double check other nodes? |
I was preparing a fix for vyperlang/titanoboa#284 and wanted to use the technique of using |
cyberthirst
approved these changes
Aug 27, 2024
charles-cooper
changed the title
Stmt AST nodes
charles-cooper
changed the title
Stmt AST nodes
xrchz
pushed a commit
to xrchz/vyper
that referenced
this pull request
Sep 1, 2024
fix classification of some AST nodes for proper type checking. this is a hygienic fix, it should have no observable semantic changes.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture