fix[venom]: fix unused variables pass #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it corrupts the DFG. to see the bug before this commit, add another StoreEliminationPass after RemoveUnusedVariablesPass.
harkal
approved these changes
Sep 26, 2024
|
@harkal should we just invalidate the dfg instead? |
charles-cooper
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it corrupts the DFG. to see the bug before this commit, add another StoreEliminationPass after RemoveUnusedVariablesPass.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture