Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor[lang]: remove translated fields for constant nodes #4287

Merged

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Oct 11, 2024

What I did

Remove deprecated properties for AST nodes when using python versions <3.8, which were translated to the new properties for python versions >=3.8.

How I did it

How to verify it

Commit message

This commit removes the `.s` field from the AST for string-like
constants. These were deprecated in the Python AST in 3.8; we no longer
need to translate them for our AST.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@tserg tserg marked this pull request as ready for review October 12, 2024 01:53
@charles-cooper charles-cooper changed the title refactor[ux]: remove translated fields for constant nodes refactor[lang]: remove translated fields for constant nodes Oct 13, 2024
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@charles-cooper charles-cooper enabled auto-merge (squash) October 13, 2024 18:35
@charles-cooper charles-cooper merged commit 61f7f4e into vyperlang:master Oct 13, 2024
155 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants