Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix parse errors for huge and empty nodes #102

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

zzamboni
Copy link
Contributor

  • Enabled the "huge_tree" option in the XML parser to prevent the "xmlSAX2Characters: huge text node" error.
  • Fixed a "list index out of range" error that happened on some notes with title but no content.

Fixes #101.

- Enabled the "huge_tree" option in the XML parser to prevent the
  "xmlSAX2Characters: huge text node" error.
- Fixed a "list index out of range" error that happened on some notes
  with title but no content.

Fixes vzhd1701#101.
@zzamboni zzamboni mentioned this pull request Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #102 (3a8fd42) into master (b0d3066) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines         1519      1521    +2     
=========================================
+ Hits          1519      1521    +2     
Files Coverage Δ
enex2notion/enex_parser_xml.py 100.00% <ø> (ø)
enex2notion/note_parser/note.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vzhd1701 vzhd1701 merged commit 0520e93 into vzhd1701:master Oct 27, 2023
@vzhd1701
Copy link
Owner

Thank you very much for your help, @zzamboni!

@zzamboni
Copy link
Contributor Author

Thanks to you @vzhd1701 for your quick response, and for your work on enex2notion 😊

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: parse error
2 participants