Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: copy and refacotor the code from DDSP_SVC #1017

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shdancer
Copy link

I see the feature request from issue #762. Then, I referenced the newest code from DDSP-SVC 4.0 and refactored the DDSP-SVC code. Here are several changes and the reasons:

According to the recommendation of DDSP-SVC, there's no need to pass the DDSP model; only the Diff model is required. So, I changed the frontend code to allow the model to be empty.
Referring to gui_diff.py in DDSP-SVC's repository, I modified the settings of the DDSP-SVC voice changer.
Known bugs:
When the chunk size is too small, it seems that DDSP-SVC itself will encounter an error related to f0_extraction.

This is my first time doing a PR. If @w-okada can help me merge, I would be really apppreciated for that.

Copy link
Contributor

github-actions bot commented Nov 24, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@shdancer
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@w-okada
Copy link
Owner

w-okada commented Nov 27, 2023

we cannot use praat-parselmouth because of license issue.

@shdancer
Copy link
Author

shdancer commented Nov 27, 2023

So if I remove the praat-parselmouth, will it be safe? In fact, the project is not using parselmouth as a f0_extractor besiedes.


Already remove praat-parselmout @w-okada

@yxlllc
Copy link

yxlllc commented Dec 10, 2023

So if I remove the praat-parselmouth, will it be safe? In fact, the project is not using parselmouth as a f0_extractor besiedes.

Already remove praat-parselmout @w-okada

ddsp-svc is using rmvpe as default f0 extractor now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants