Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update VoiceOver navigation commands for Command and Toggle Button #1048

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Update VoiceOver navigation commands for Command and Toggle Button #1048

merged 8 commits into from
Mar 12, 2024

Conversation

IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Mar 12, 2024 •
edited
Loading

Preview Tests
Resolves #1030

  • Update VoiceOver navigation commands for Command Button
  • Update navigation VoiceOver commands for Toggle Button

@IsaDC
Copy link
Contributor Author

IsaDC commented Mar 12, 2024

Hi @howard-e could you please help me out with all these errors? Do I need to update something on my computer?
Thank you kindly.

@IsaDC IsaDC requested a review from howard-e March 12, 2024 20:02
howard-e
howard-e reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsaDC the presentationNumber value is missing for the newly added rows.

I've left inline suggestions for what those values could be just based on the other presentationValues around it, but please adjust if I'm wrong!

IsaDC and others added 6 commits March 12, 2024 14:44
@IsaDC @howard-e
Update tests/command-button/data/voiceover_macos-commands.csv
d106030 
Add missing values.

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
@IsaDC @howard-e
Update tests/command-button/data/voiceover_macos-commands.csv
64ff7dc 
Add missing values

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
@IsaDC @howard-e
Update tests/toggle-button/data/voiceover_macos-commands.csv
51ea4de 
Add missing values

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
@IsaDC @howard-e
Update tests/toggle-button/data/voiceover_macos-commands.csv
629e6d5 
Add missing values

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
@IsaDC @howard-e
Update tests/toggle-button/data/voiceover_macos-commands.csv
71810d2 
Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
@IsaDC @howard-e
Update tests/toggle-button/data/voiceover_macos-commands.csv
9c747e5 
Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
@IsaDC IsaDC merged commit 5d5ba08 into master Mar 12, 2024
6 checks passed
@IsaDC IsaDC deleted the tests/buttons-update-VO-commands branch March 12, 2024 21:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@howard-e howard-e howard-e left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback: "Navigate backwards to a pressed toggle button" (Toggle Button, Test 12, V23.12.14)
2 participants
@IsaDC @howard-e