Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor Radio Group Example Using Roving tabindex Test Plan to V2 Test Format #1156

Merged
merged 11 commits into from
Dec 12, 2024

Conversation

IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Nov 6, 2024

Preview Tests

  • Convert previous test plan version to v2 format
  • Remove previous test plan csv files and log
  • update assertions.csv file
  • Update tests.csv file
  • Update ATs commands
  • Add htmlLin to references.csv
  • Update references.csv

@IsaDC IsaDC requested a review from mcking65 November 6, 2024 17:49
@IsaDC
Copy link
Contributor Author

IsaDC commented Nov 13, 2024

@mcking65 Ready for review.

@mcking65
Copy link
Contributor

mcking65 commented Dec 4, 2024

@IsaDC

  1. The setup script is not setting focus for tests 5 through 15. It's probably an ID issue. Focus seems to be set on the body. Note: I made sure window is maximized.
  2. Test 7: NVDA is missing down arrow with browse mode on.
  3. Test 8: NVDA is missing up arrow with browse mode on.
  4. Test 9: NVDA is missing down arrow with browse mode on.
  5. Test 10: NVDA is missing up arrow with browse mode on.
  6. Test 11: JAWS should have a mode switch assertion for the enter key. Note: NVDA does not switch modes, and I assume that is an intentional NVAccess decision, so we should not assert it for NVDA. Unlike some other composite widgets, there valid arguments for either behavior with radio buttons.

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsaDC

After fixing and verifying the 6 items I mentioned in my prior comment, please go ahead and merge.

@IsaDC
Copy link
Contributor Author

IsaDC commented Dec 4, 2024

h> @IsaDC

  1. The setup script is not setting focus for tests 5 through 15. It's probably an ID issue. Focus seems to be set on the body. Note: I made sure window is maximized.
  2. Test 7: NVDA is missing down arrow with browse mode on.
  3. Test 8: NVDA is missing up arrow with browse mode on.
  4. Test 9: NVDA is missing down arrow with browse mode on.
  5. Test 10: NVDA is missing up arrow with browse mode on.
  6. Test 11: JAWS should have a mode switch assertion for the enter key. Note: NVDA does not switch modes, and I assume that is an intentional NVAccess decision, so we should not assert it for NVDA. Unlike some other composite widgets, there valid arguments for either behavior with radio buttons.

Hi @mcking65
in the Radio Group Example Using aria-activedescendant Test Plan, up/down arrow commands for NVDA are also missing (see comments 2-5). Should we add them to both?

@IsaDC
Copy link
Contributor Author

IsaDC commented Dec 4, 2024

@jscholes Please take a look at the setupScripts that set focus on radio buttons—they don't seem to be working correctly and need fixing.

@jscholes
Copy link
Contributor

jscholes commented Dec 4, 2024

@IsaDC Fixed.

@jscholes jscholes removed their assignment Dec 4, 2024
@IsaDC IsaDC merged commit 4936d3b into master Dec 12, 2024
3 checks passed
@IsaDC IsaDC deleted the tests/radiogroup-roving-tabindex-refactor branch December 12, 2024 20:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants