Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement Feedback: Request Info Slider Test #1165

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Dec 3, 2024

Preview Tests

Resolves #1145

@IsaDC
Copy link
Contributor Author

IsaDC commented Dec 4, 2024

Hi @howard-e ,
Could you please take a look at this workflow run? It's failing, and I'm unsure why. I built the tests locally without encountering any issues.
Thanks in advance!

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @IsaDC!

@howard-e
Copy link
Contributor

howard-e commented Dec 4, 2024

Hi @howard-e , Could you please take a look at this workflow run? It's failing, and I'm unsure why. I built the tests locally without encountering any issues. Thanks in advance!

Hi @IsaDC there was an unnecessary check with the test snapshots. No issues have been found with the changes you've made.

#1166 will resolve it so if you'd like to leave an approval on that PR for us to then merge in here, it will clear up that error

@IsaDC IsaDC merged commit ed744e7 into master Dec 4, 2024
7 checks passed
@IsaDC IsaDC deleted the tests/color-viewer-slider-feedback branch December 4, 2024 20:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JAWS Changes Requested: "Request information about a slider" (Color Viewer Slider, Test 3, V24.06.26)
3 participants