Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor Link Example 1 (span element with text content) test plan to V2 test format #991

Closed
wants to merge 5 commits into from

Conversation

IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Sep 28, 2023

…text content) test plan to the V2 test format
@IsaDC IsaDC marked this pull request as draft September 28, 2023 19:58
@IsaDC IsaDC marked this pull request as ready for review December 1, 2023 17:39
@IsaDC IsaDC requested a review from mcking65 December 1, 2023 17:41
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsaDC

I made one correction to the nav back to link command for VoiceOver. I change it to "shift+l". It was previously "l".

After doing that, I noticed there are 32 files changed in this PR. In addition to the link tests, there are changes to button and meter as well as to package.json and package-lock.json.

The easiest way to fix that is make a fresh PR with the files we want. I'll close this PR and make that new one, including all the current link/data.

@mcking65
Copy link
Contributor

mcking65 commented Dec 6, 2023

replaced by #1013

@mcking65 mcking65 closed this Dec 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants