Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor CLI tests and improvements on the -version option #1590

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

rdeltour
Copy link
Member

  • Migrate CLI tests to Cucumber
  • Allow -version to be used when checking a file
  • No longer display "EPUBCheck completed" and short stats when displaying informational output only (version, help message)

Split the definitions of configuration-related steps in two classes:
- `TestEnvironment` contains generic test configuration steps,
  like setting the locale or the location of test files
- `EPUBCheckConfiguration` contains the steps used to conifugre an
  EPUBCheck instance (version, mode, profile, etc)
- Allow using the version option when checking a file. The CLI will
  display the version info and the carry on checking the file.
- The "EPUBCheck completed" message, along with the short stats on
  messages (fatals/errors/warnings/infos) is no longer displayed when
  the CLI only displays informational output (help message or version).

Fixes #1533
@rdeltour rdeltour added this to the Next maintenance release milestone Dec 28, 2024
@rdeltour rdeltour self-assigned this Dec 28, 2024
Base automatically changed from feat/html-schemas-update to main December 29, 2024 00:04
@rdeltour rdeltour merged commit 26fd614 into main Dec 29, 2024
5 checks passed
@rdeltour rdeltour deleted the fix/cli-version-option branch December 29, 2024 00:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant