fix: mailto URLs were reported as missing resources
#1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a regression bug introduced in PR #1582, in the implementatiom of `OCFContainer#isRemote(URL)`. The buggy implementation considered `mailto` URLs as local URLs. As a result, it reported an error as no matching local resource could be found in the container. The new implementation says a URL is remote when it is not a `data` URL and is not the URL of a resource in the container. Fix #1595
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression bug introduced in PR #1582, in the implementatiom of
OCFContainer#isRemote(URL).The buggy implementation considered
mailtoURLs as local URLs. As a result, it reported an error as no matching local resource could be found in the container.The new implementation says a URL is remote when it is not a
dataURL and is not the URL of a resource in the container.Fix #1595