Throw InvalidNodeTypeError for doctype more eagerly #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches how major engines behave and is covered by multiple tests in WPT already. Closes w3c#118.
awesomekling
added a commit
to awesomekling/ladybird
that referenced
this pull request
Nov 16, 2024
This matches the behavior of all major engines, and is covered by hundreds of subtests in WPT. Spec PR: w3c/selection-api#342
awesomekling
added a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Nov 16, 2024
This matches the behavior of all major engines, and is covered by hundreds of subtests in WPT. Spec PR: w3c/selection-api#342
|
@siusin : what should we do to have @awesomekling allowed to contribute this PR? |
nico
pushed a commit
to nico/serenity
that referenced
this pull request
Nov 17, 2024
This matches the behavior of all major engines, and is covered by hundreds of subtests in WPT. Spec PR: w3c/selection-api#342 (cherry picked from commit 13bd52249d3fe674b8c11049eb66a305e058ee6f)
nico
pushed a commit
to SerenityOS/serenity
that referenced
this pull request
Nov 17, 2024
This matches the behavior of all major engines, and is covered by hundreds of subtests in WPT. Spec PR: w3c/selection-api#342 (cherry picked from commit 13bd52249d3fe674b8c11049eb66a305e058ee6f)
Working on it. It’ll take another 7 days, til the 25th |
Ended up being able to fast-track it. Andreas is now a member of the Web Editing working group — so after the patch in this PR gets reviewed and approved, it can be merged into the Selection API spec. |
|
Great. Thank you! |
rniwa
approved these changes
Nov 20, 2024
gotlougit
pushed a commit
to gotlougit/ladybird
that referenced
this pull request
Nov 21, 2024
This matches the behavior of all major engines, and is covered by hundreds of subtests in WPT. Spec PR: w3c/selection-api#342
nico-engels
pushed a commit
to nico-engels/ladybird
that referenced
this pull request
Nov 23, 2024
This matches the behavior of all major engines, and is covered by hundreds of subtests in WPT. Spec PR: w3c/selection-api#342
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches how major engines behave and is covered by multiple tests in WPT already.
Closes #118.
Supersedes #86.
Note: I didn't touch
setBaseAndExtenthere, since Gecko doesn’t throw on doctype but WebKit and Blink do.Preview | Diff