-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Emit null instead of empty object for validateAshHooks
#81
base: main
Are you sure you want to change the base?
Conversation
This was left to minimize report.json changes in earlier refactoring. Fixing it now should only affect the report.json structure but not report.html.
f4707eb
to
09522aa
Compare
validateAshHooks
I've trimmed this PR to only the remaining TODO. |
The diff shows
which I don't understand and wouldn't have expected. Any insight? |
Oh, I didn't anticipate this, but it's because of this logic: Lines 55 to 61 in 39443ae
@dontcallmedom maybe this should be changed to always use the object form? If such a change is landed first, this change should then be a no-op. |
changing to always use object form makes sense to me, but will probably need changes in downstream usage of the JSON results (which points toward the need of setting up a JSON schema for the results I think) |
As it happens I was just working on using a JSON schema to validate w3c.json, if that works out it should be straightforward (ish) to use it for report.json as well. Let's leave this PR hanging, it's not urgent in any way. |
This was left to minimize report.json changes in earlier
refactoring. Fixing it now should only affect the report.json
structure but not report.html.