Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WAI website update 2024-12-02 #313

Merged
merged 7 commits into from
Dec 10, 2024
Merged

WAI website update 2024-12-02 #313

merged 7 commits into from
Dec 10, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 2, 2024

This is an automated pull request to publish ACT content to the WAI website.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for wai-wcag-act-rules ready!

Name Link
🔨 Latest commit 4368485
🔍 Latest deploy log https://app.netlify.com/sites/wai-wcag-act-rules/deploys/675687e8446619000853fd10
😎 Deploy Preview https://deploy-preview-313--wai-wcag-act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniel-montalvo
Copy link
Contributor

Hi @shawna-slh @remibetin

This PR incorporates changes based on an update to the ACT-Tools framework, which contains significant changes.

Happy to re-schedule this for 10 Dec when @remibetin is back.

@shawna-slh
Copy link
Contributor

Thank you. My week just got more complicated with family medical issues. If it's not urgent, I prefer to wait for Rémi next week.

WilcoFiers and others added 3 commits December 5, 2024 10:12
* Update a1b64e Pass 2 to add role

* Add a support note for issue 1909 regarding cycle to browser

* Add a passing modal example

* Fix spacing

* Fix spacing

---------

Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
Copy link
Contributor

@shawna-slh shawna-slh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @daniel-montalvo on content and @remibetin for high-level QA. Thanks!

<li><a href="https://www.w3.org/TR/WCAG21/#cc5">Learn more about WCAG Non-Interference</a></li>
<li><strong>Required for conformance</strong> to WCAG 2.1.</li>
<li><a href="https://www.w3.org/TR/WCAG22/#cc5">Learn more about WCAG Non-Interference</a></li>
<li><strong>Required for conformance</strong> to WCAG 2.2.</li>
Copy link
Member

@remibetin remibetin Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-montalvo Any reason not to use "Required for conformance to WCAG 2.0 and later"?

"Required for conformance to WCAG 2.x and later" is a widely used pattern in ACT Rules. Readers might interpret "Required for conformance to WCAG 2.2" in a restricted way (i.e. not required for conformance to WCAG 2.0 or 2.1)

[examples of accessible name]: https://act-rules.github.io/pages/examples/accessible-name/
[examples of included in the accessibility tree]: https://act-rules.github.io/pages/examples/included-in-the-accessibility-tree/
[flat tree]: https://drafts.csswg.org/css-scoping/#flat-tree 'Definition of flat tree'
[html aam image button]: https://www.w3.org/TR/html-aam-1.0/#input-type-image 'HTML Accessibility API Mapping, image button'
[html aam]: https://www.w3.org/TR/html-aam-1.0/#html-attribute-state-and-property-mappings 'Specification of HTML attributes value mapping to ARIA states and properties'
[idl attribute]: https://heycam.github.io/webidl/#idl-attributes "Definition of Web IDL Attribute (Editor's Draft)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@remibetin remibetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-montalvo I have added a couple comments for your consideration. Not sure they are blockers though.

@daniel-montalvo
Copy link
Contributor

Thanks @remibetin for your comments and suggestions.
I will open dedicated issues for them in the source repo ad we will address them later. My understanding is that these are not blockers for publishing these updates.

Copy link
Contributor

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I propose that we addressed received comments in later updates.

@remibetin remibetin merged commit 067f8c9 into publication Dec 10, 2024
8 checks passed
@remibetin
Copy link
Member

@daniel-montalvo Published. Please QA.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants