-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
SRI: upgrade examples to sha384? #477
Comments
Sounds good to me. |
I'd say no because that involves implementation changes too. Let's ship what we have now. |
Yes! |
Sorry completely forgot level 1 hasn't shipped yet. (I meant more algos for On Fri, Sep 18, 2015 at 9:35 AM Frederik notifications@github.com wrote:
|
Yeah, that would be an easy V2 feature. |
Taking the sha256 → sha384 rewrite |
My patch is nearly done, mostly search&replace work, but I have a few questions.. I guess it's too late for SRIv1 to kill SHA256 completely, but we are arguing that SHA256 is a good thing in the document, when the NSA claims it is not anymore (and they probably know better?). So I suppose we will have to keep this one?
And this one?
I'd rather not say that SHA256 really is a good baseline? Not sure whether we can still modify this sentence. Most tooling we have and CDNs we talk to unfortunately default to SHA256 by now :-/ |
I think we can simply say that SHA384 is a good baseline and simply not talk about SHA256. We should probably keep supporting SHA256 though. It feels premature to deprecate it. |
Agree with @fmarier. I don't think it's as straightforward as "sha256 is no good," and even if that were the case, we'd have a lot bigger problems (e.g. SSL certs) than SRI. This change lgtm. |
+1 .. the SRI hashes are likely delivered over SSL that reduces to SHA-2 |
Rewrite instance of SHA256 to SHA384, see issue #477
The NSA no longer recommends SHA-256 apparently: https://www.nsa.gov/ia/programs/suiteb_cryptography/index.shtml
Should we upgrade our examples to use
sha384
instead ofsha256
?The text was updated successfully, but these errors were encountered: