Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

framerate vs frameRate #588

Closed
dontcallmedom opened this issue Oct 19, 2022 · 8 comments
Closed

framerate vs frameRate #588

dontcallmedom opened this issue Oct 19, 2022 · 8 comments
Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior

Comments

@dontcallmedom
Copy link
Member

VideoEncoderConfig uses lower-case framerate (as does media capabilities), when other specs (screen capture, media capture and streams, webxr) use the camel-case frameRate.

Aligning would be an improvement from a developer ergonomics perspective

@dalecurtis
Copy link
Contributor

Defer to @padenot @aboba - since Chrome has already shipped we'd probably just have to add "frameRate" as equally valid versus removing "framerate"

@padenot
Copy link
Collaborator

padenot commented Oct 20, 2022

Too bad, but it's a bit late at this point indeed. I assume this attribute sees a lot of use out there.

@dontcallmedom
Copy link
Member Author

the future being longer than the past, can we move to frameRate and have implementation provides a backwards compat layer?

@dalecurtis
Copy link
Contributor

I don't mind accepting both, but defer to @padenot @aboba @youennf.

@youennf
Copy link
Contributor

youennf commented Oct 20, 2022

bitrate is a similar field in VideoEncoderConfig and is consistently lower cased in all APIs AFAIK.
Is it fine to have frameRate but bitrate in the same dictionary?

@dalecurtis
Copy link
Contributor

We seem to use bitrate everywhere AFAICT. bitrate does seem to have "formal" recognition from dictionaries though: https://www.merriam-webster.com/dictionary/bit%20rate whereas I can't find an equivalent for framerate.

I personally prefer framerate and bitrate but am always sympathetic to consistency arguments.

@dalecurtis
Copy link
Contributor

A similar CamelCase or flatcase issue is coming up with #594

@aboba aboba added the editorial changes to wording, grammar, etc that don't modify the intended behavior label Mar 16, 2023
@Djuffin
Copy link
Contributor

Djuffin commented May 11, 2023

I don't think we'll be renaming anything at this point. So let's live with what we have.

@Djuffin Djuffin closed this as completed May 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior
Projects
None yet
Development

No branches or pull requests

6 participants