Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Need to make dictionary members more consistent in coding style? #658

Closed
helaozhao opened this issue Mar 28, 2023 · 4 comments
Closed

Need to make dictionary members more consistent in coding style? #658

helaozhao opened this issue Mar 28, 2023 · 4 comments
Labels

Comments

@helaozhao
Copy link
Contributor

just as the members in opus-encoder-config. There's a kind of style of CamelCase, such as frameDuration, and a kind of style of flatcase as well.

Does there still have an opportunity to make them consistent, like in camel case?

@tidoust
Copy link
Member

tidoust commented Mar 28, 2023

Thanks for the report. Closing as duplicate as I think this is being tracked in #588. Feel free to reopen (or complete #588) if I missed something!

@tidoust tidoust closed this as completed Mar 28, 2023
@helaozhao
Copy link
Contributor Author

Thanks for the report. Closing as duplicate as I think this is being tracked in #588. Feel free to reopen (or complete #588) if I missed something!

I think there is a little different in that #588 mainly discusses the attribute bitrate, and it looks that there has got an agreement ( bitrate is proper in style).
In this issue I referred to the attributes in opus-encoder-config, especially the attributes of packetlossperc and useinbandfec.
It's great if has chance to change them.

@chrisn
Copy link
Member

chrisn commented Mar 28, 2023

These opus attributes were previously discussed here: https://github.com/w3c/webcodecs/pull/594/files/f133d9401d90191f7de543cadfe0b3ae8acf2b42#r1001142719

Personally, I would prefer packetLossPerc, useInbandFec, useDtx (or should that be useInbandFEC and useDTX, following suggested casing rules?) But that said, an argument was also made for being consistent with ORTC.

@chrisn chrisn reopened this Mar 28, 2023
@bdrtc
Copy link
Contributor

bdrtc commented Mar 30, 2023

one question: as w3c spec, we should follow the casing-rules of w3c or follow special codec RFC ? I prefer follow w3c design principles personally.

@aboba aboba added Question won't fix No changes labels Jul 6, 2023
@aboba aboba closed this as completed Jul 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants