Merge doohickey branch to master #175

juberti · 2015-01-08T21:20:57Z

No description provided.

Fix the parameter descriptions for RTCAddTrackEvent

Merge juberti:master to doohickey branch

…treamTrack's.

…ns though.

…cks.

Updated to use MediaStreamTrack instead of MediaStream. I'm merging this to the doohickey branch, so that work can continue there.

Clean extraneous whitespace Add <code> elements as needed Change sequence -> array as suggested by DOM Minor spelling and indentation fixups

Cleanups

adam-be · 2015-01-16T14:59:51Z

webrtc.html

            <!--  [[OPEN ISSUE: How many <code>MediaStream</code>s are created
                when you receive multiple conflicting pranswers?]] --></p>
          </li>

          <li>
+            Add <var>track</var> to the <code>MediaStream</code>(s) <var>streams</var>


The variable "streams" turns up out of the blue here and without a proper description.

adam-be · 2015-01-16T15:04:04Z

Let's merge this rather soon and continue to work on in from within the document.

fluffy · 2015-01-22T04:25:16Z

We (someone, does not need to be Justin) need to fix the merge conflicts before we really review on all this. I'm having a hard time sorting out the parts that were removed.

fluffy · 2015-01-22T04:32:53Z

webrtc.html

+
+      <p>The actual encoding and transmission of <code>MediaStreamTrack</code>s is managed through
+      objects called <code>RTCRtpSender</code>s. Similarly, the reception and decoding of
+      <code>MediaStreamTrack</code>s is managed through objects called <code>RTCRtpReceiver</code>s.</p>


I think we need more here to explain what a RtpSender / Receiver represents. I'm trying to get at the issue of how many of them do you have. Are they 1:1 with tracks, etc ...

Seems to me this is the right place to explain they are 1:1 with tracks, and the issues around the timing of when they are created

fluffy · 2015-01-22T05:19:18Z

webrtc.html

+          by all objects implementing the <code><a>RTCPeerConnection</a></code>
+          interface. It is called any time a <code>MediaStreamTrack</code> is added
+          by the remote peer. This will be fired only as a result of
+          <code>setRemoteDescription</code>. ontrack happens as early as


not sure this is right. Early media creates a track before the setRemote. In the case of a PRanswer one can get multiple tracks before after a PRanswer but before the Answer.

For PRANSWER, there is no issue - PRANSWER is a remote description. The tricky part is media before PRANSWER. We need to decide if we are going to handle this or not.

… a MediaStreamTrack

… tracks

…stream as it's created

adam-be · 2015-01-27T10:19:21Z

I've updated the doohickey branch with fixes for my comments

Address comments from Cullen, and one from Adam

Section 4 is now agnostic of MediaStreamTracks, and this lines up well with the new note about when MSTs are generated.

juberti · 2015-01-31T02:20:12Z

Just uploaded a new version. I believe all comments have been addressed.

I will take one more pass over this today to see if there are any remaining nits, but I think this is ready to be merged now.

fluffy · 2015-01-31T15:08:28Z

.travis.yml

- - phantomjs --ignore-ssl-errors=true --ssl-protocol=tlsv1 respec/tools/respec2html.js -e -w webrtc.html output.html
- - python webidl-checker/webidl-check output.html
- - "! (perl -T linkchecker/bin/checklink -S 0  -q -b output.html |grep  \"^\")"
-env: WIDLPROC_PATH=$TRAVIS_BUILD_DIR/widlproc/obj/widlproc


Need to not delete this

OK, I think this was just a merge thing. Will fix.

Merge doohickey branch to master

juberti and others added 14 commits October 14, 2014 23:11

Add RTCRtpSender, RTCRtpSender, and friends

ce5794c

Respond to CR comments

dc0b216

Merge anchor fix from @dontcallmedom

9506f8b

AddTrackEvent -> RTCAddTrackEvent

2e0075a

Fix the parameter descriptions for RTCAddTrackEvent

PR feedback; onaddtrack -> ontrack

fbf6642

no change

456df99

Merge pull request #18 from juberti/master

18e893f

Merge juberti:master to doohickey branch

Editorial, changed some text that talks about MediaStream's to MediaS…

1243001

…treamTrack's.

Fixed some respec errors. The "Duplicate definition of 'track'" remai…

6ec919a

…ns though.

More edits associated with moving from sending streams to sending tra…

711a49f

…cks.

Fixed (hopefully) the link error spotted by Adam when reviewing PR #40.

fe6fdeb

Merge pull request #40 from stefhak/doohickey

53f614e

Updated to use MediaStreamTrack instead of MediaStream. I'm merging this to the doohickey branch, so that work can continue there.

Cleanups

aa2bb9f

Clean extraneous whitespace Add <code> elements as needed Change sequence -> array as suggested by DOM Minor spelling and indentation fixups

Merge pull request #174 from juberti/doohickey

d4bbf46

Cleanups

This was referenced Jan 15, 2015

Change addStream to addTrack; add RTCRtpSender/RTCRtpReceiver #3

Closed

Remove RTCPeerConnection.createDTMFSender and add RTCRtpSender.dtmf. #167

Closed

adam-be reviewed Jan 16, 2015
View reviewed changes

fluffy reviewed Jan 22, 2015
View reviewed changes

adam-be added 8 commits January 22, 2015 15:25

Update misleading local/remoteDescription attribute text

e1372b8

Define streams in the algorithm to represent an incoming component as…

2b020e2

… a MediaStreamTrack

Remove paragraph not applicable with the move from sending streams to…

d6b4622

… tracks

Remove step 4.3 in the algorithm where the UA removes incoming tracks

b1ebed9

Fixed typo

7738aa9

Include receiver and streams attributes in the RTCTrackEvent description

8165d3d

Remove redundant sentence

89da305

Bring back note about not dispatching events when adding tracks to a …

c3afe0f

…stream as it's created

juberti added 4 commits January 30, 2015 13:46

Merge branch 'master' into doohickey

da69f13

PR feedback; add note about early media

9444b4f

Address comments from Cullen, and one from Adam

Move incoming MST text to the RTP Media section

092504a

Section 4 is now agnostic of MediaStreamTracks, and this lines up well with the new note about when MSTs are generated.

Fix ReSpec complaint regarding track

ceecbf2

Fix typos when rereading, and note ICE issues

a14fe06

fluffy reviewed Jan 31, 2015
View reviewed changes

fluffy and others added 3 commits January 31, 2015 09:11

fix merge

8631ca9

Add hidden files from master

d985748

Use the correct event name

089100a

fluffy added a commit that referenced this pull request Feb 18, 2015

Merge pull request #175 from w3c/doohickey

8385480

Merge doohickey branch to master

fluffy merged commit 8385480 into master Feb 18, 2015

juberti mentioned this pull request Feb 26, 2015

RTCRtpSender / Receiver objects need to be added to the specification #161

Closed

alvestrand mentioned this pull request Apr 16, 2015

Transport objects should be added to the specification #126

Closed

juberti deleted the doohickey branch August 28, 2015 00:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge doohickey branch to master #175

Merge doohickey branch to master #175

juberti commented Jan 8, 2015

adam-be Jan 16, 2015

adam-be commented Jan 16, 2015

fluffy commented Jan 22, 2015

fluffy Jan 22, 2015

juberti Jan 30, 2015

fluffy Jan 22, 2015

juberti Jan 30, 2015

adam-be commented Jan 27, 2015

juberti commented Jan 31, 2015

fluffy Jan 31, 2015

juberti Jan 31, 2015

Merge doohickey branch to master #175

Merge doohickey branch to master #175

Conversation

juberti commented Jan 8, 2015

adam-be Jan 16, 2015

Choose a reason for hiding this comment

adam-be commented Jan 16, 2015

fluffy commented Jan 22, 2015

fluffy Jan 22, 2015

Choose a reason for hiding this comment

juberti Jan 30, 2015

Choose a reason for hiding this comment

fluffy Jan 22, 2015

Choose a reason for hiding this comment

juberti Jan 30, 2015

Choose a reason for hiding this comment

adam-be commented Jan 27, 2015

juberti commented Jan 31, 2015

fluffy Jan 31, 2015

Choose a reason for hiding this comment

juberti Jan 31, 2015

Choose a reason for hiding this comment