Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disallow serialization of RTCCertificate except for storage. #2297

Closed
wants to merge 1 commit into from

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Sep 11, 2019

Fixes #2257.

@annevk PTAL.


Preview | Diff

@jan-ivar jan-ivar added the Needs Test Needs a WPT test label Sep 11, 2019
@jan-ivar jan-ivar self-assigned this Sep 11, 2019
@jan-ivar
Copy link
Member Author

Are we sure this covers all the same corners as before, even with CORS and iframe.contentDocument poking?

@annevk
Copy link
Member

annevk commented Sep 12, 2019

CORS affects networking, not JavaScript access.

If you use document.domain though you'd be able to store an object from a different origin (but same site) in your origin. But you'd also have direct access to that object in that case.

The other potential problem here is that folks might use these objects with postMessage() and that would no longer work. Are all user agents on board with implementing that? Is there test coverage to ensure they do?

@jan-ivar
Copy link
Member Author

Closing given #2257 (comment).

@annevk Is something like a boolean sameOrigin serialization option on anyone's radar?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Needs Test Needs a WPT test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making RTCCertificate throw when serialized when _forStorage_ is false
3 participants