Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix lint issues #413

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Fix lint issues #413

merged 2 commits into from
Feb 8, 2023

Conversation

gibson042
Copy link
Contributor

@gibson042 gibson042 commented Jan 6, 2023

As observed in failure of the latest deploy job:

bikeshed --die-on=fatal spec index.bs build/index.html
LINT: Your document appears to use spaces to indent, but line 795 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 796 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 797 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 798 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 799 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 803 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 804 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 811 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 812 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 813 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 814 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 815 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 816 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 817 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 818 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 819 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 820 starts with tabs.
LINT: Your document appears to use spaces to indent, but line 821 starts with tabs.
FATAL ERROR: Line 703 isn't indented enough (needs 1 indent) to be valid Markdown:
"  (e.g. sends information to a document)"
 ✘  Did not generate, due to fatal errors

Preview | Diff

@cynthia
Copy link
Member

cynthia commented Feb 7, 2023

Thank you for the submission - we realized that we have some consistency issues across our repositories, and we'd like to first only address the fatal errors if possible (as the formatting changes would likely clobber them).

I'm happy to do that, let us know if you can send in a revised PR.

@gibson042
Copy link
Contributor Author

Isn't that this PR? What changes are you looking for?

@LeaVerou
Copy link
Member

LeaVerou commented Feb 7, 2023

Isn't that this PR? What changes are you looking for?

This PR includes a fix for the fatal error, as well as formatting changes from tabs to spaces. We have no resolution about the type of indentation we want to use (which is why the inconsistency happened in the first place). We should probably decide on that first before we fix the inconsistency one way or the other.
Regardless, the indentation changes were also proposed by #405, so if you could remove them from this one so we can merge the fix to the fatal error, that would be helpful (although the same fix is included in #408, which may end up getting merged first)

@gibson042
Copy link
Contributor Author

@cynthia @LeaVerou OK, done.

@cynthia cynthia self-requested a review February 8, 2023 01:12
@cynthia cynthia merged commit 6d34b09 into w3ctag:main Feb 8, 2023
@gibson042 gibson042 mentioned this pull request Feb 9, 2023
hober pushed a commit that referenced this pull request Apr 20, 2023
* Fix lint issues

* Revert replacement of tabs with spaces
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants