✨ HTMLViewer에 MainImage 기능 추가 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whwoohw
reviewed
Aug 3, 2023
whwoohw
approved these changes
Aug 3, 2023
Limchansol
reviewed
Aug 3, 2023
| import { usePathname } from 'next/navigation'; | ||
|
|
||
| import { SegmentNode, main } from '@/types/page'; | ||
|
|
||
| export default function useCurrentSegmentNode(): SegmentNode { |
There was a problem hiding this comment.
아마 내비 만들 때까지만 해도 hooks 폴더가 없었을 거라 여기에 써두었을 것으로 추정되는데 얘도 훅이라면 hooks에 넣는 건 어떠신가요!
이 함수 밑에 있는 findChildWithName은 페이지들이랑 관련된 것 같으니 utils/page.ts에 넣어놓고...?
크게 중요한 부분은 아니니 애매하다면 편한 대로 해도 무방할 듯합니다!
There was a problem hiding this comment.
findChildWithName은 export할 필요가 없어서 useCurrentSegmentNode랑 같이 가도 좋을 것 같고, useCurrentSegmentNode는 hooks로 옮길게요!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 사항
추가 사항