feat: add support for alternative ordering strategies #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry! I didn't mean to close this, I renamed the master branch to main... I should have switched the target here first. |
|
@iiian if you'd like to re-open the PR against |
wagoodman
force-pushed
the
feat/sort-by-size
branch
from
e41f394 to
5128684
Compare
|
@iiian I recreated the master branch temporarily to get this in (I didn't think of that earlier). Just force pushed to rebase. |
|
Rad! |
|
FYI: This closes #89 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #341.
Adds a default hotkey of
ctrl+oto flip between A-Z sort order and numerical sort-by-size-desc on the right-side pane.The approach to implementing this feature was to find all of the places in code that enforce the order in which file-system nodes in the selected layer are displayed in the buffer window. Three methods were identified:
FileTree.StringBetween,FileNode.VisitDepthParentFirstandFileNode.VisitDepthChildFirst. These locations were taking theFileNode's propertyChildren map[string]*FileNodeand performingsort.Strings(keys)in order to implement alphanumeric sorting.These locations have been unified with
OrderStrategy.orderKeys(map[string]*FileNode). A factory function,GetSortOrderStrategy, tees up the corresponding ordering strategy given an enum, which it then propagates down to the three mentioned methods.Additionally, a
Size int64field has been attached toFileNodein order to cache information on directory/file size for use in the sort-by-size-desc strategy (with a simple extraction refactor of theFileNode.MetadataStringmethod.Happy New Year! 🥂