Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix a couple of bugs in parsing array type arguments in type signatures #1477

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Fix a couple of bugs in parsing array type arguments in type signatures #1477

merged 2 commits into from
Dec 24, 2024

Conversation

msridhar
Copy link
Member

We forgot to increment a variable, and we didn't handle all the primitive types.

@msridhar msridhar changed the title Fix a couple of bugs in parsing array type arguments in type signatures" Fix a couple of bugs in parsing array type arguments in type signatures Dec 24, 2024
@msridhar msridhar requested a review from liblit December 24, 2024 03:20
liblit
liblit approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@liblit liblit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests!

@github-actions GitHub Actions
Copy link

Test Results

  813 files  ±0    813 suites  ±0   4h 10m 40s ⏱️ - 8m 11s
  740 tests +1    723 ✅ +1   17 💤 ±0  0 ❌ ±0 
5 064 runs  +7  4 943 ✅ +7  121 💤 ±0  0 ❌ ±0 

Results for commit dba1345. ± Comparison against base commit aa5280a.

@msridhar msridhar merged commit ac47859 into wala:master Dec 24, 2024
11 checks passed
@msridhar msridhar deleted the fix-typesig-parsing branch December 24, 2024 03:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@liblit liblit liblit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msridhar @liblit