Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use system htslib; a couple minor tweaks #64

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

julianhess
Copy link
Contributor

The htslib submodule was getting stale; I think it's better if we use whatever system htslib is already included.

Also implemented a more efficient way of getting the number of softclipped bases, and provided a function for getting the current region index.

@julianhess
Copy link
Contributor Author

BTW, it looks like we have to update the test suite VM to include an installation of htslib.

@walaj
Copy link
Owner

walaj commented Mar 27, 2021

I think this makes sense, thanks for the updates. I'd like to see it pass the test suite first. Can you add the following to travis-before-install.sh? That should work. I made a branch jhess with this, but can't figure out how to get Travis CI to build this branch.

    ## install htslib
    mkdir htslib
    wget --no-verbose --output-document=- https://github.com/samtools/htslib/releases/download/1.12/htslib-1.12.tar.bz2 | tar xfj - --strip-components=1 -C htslib
    cd htslib && ./configure
    sudo make
    sudo make install

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants