Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

s3: exclude unnecessary transitive dependencies #101

Merged
merged 1 commit into from
Oct 26, 2022
Merged

s3: exclude unnecessary transitive dependencies #101

merged 1 commit into from
Oct 26, 2022

Conversation

benbroadaway
Copy link
Collaborator

The transitive dependencies of aws-java-sdk are numerous and large, which causes process startup time to suffer dramatically when including the s3 plugin. The plugin doesn't need the transitive dependencies.

  • Exclude aws-java-sdk transitive deps. Reduces resolved deps from 264M to 5.9M.
  • Update/add unit tests leveraging testcontainers and S3Mock.

@benbroadaway benbroadaway requested a review from a team October 21, 2022 14:00
@brig brig merged commit 4c99427 into master Oct 26, 2022
@brig brig deleted the s3-tidy branch October 26, 2022 18:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants