Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ldap-task: support for dns SRV resource record #115

Merged
merged 4 commits into from
Feb 23, 2023
Merged

ldap-task: support for dns SRV resource record #115

merged 4 commits into from
Feb 23, 2023

Conversation

amithkb
Copy link
Contributor

@amithkb amithkb commented Feb 2, 2023 •
edited
Loading 

configuration:
  runtime: concord-v2
...
  arguments:
    ldapParams:
      dnsSrvRr: 
        name: "_ldap._tcp.domain.com"
        protocol: "ldaps"
        port: "3269"
  • added support for ldapParams in v2
  • cleaned up duplicate retries

@amithkb amithkb requested a review from a team February 2, 2023 08:44
@amithkb amithkb added the need docs Documentation required label Feb 3, 2023
@mtkunkel mtkunkel merged commit f163d3c into master Feb 23, 2023
@mtkunkel mtkunkel deleted the srv-ldap-task branch February 23, 2023 19:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benbroadaway benbroadaway benbroadaway approved these changes

@mtkunkel mtkunkel mtkunkel approved these changes

Assignees
No one assigned
Labels
need docs Documentation required
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amithkb @benbroadaway @mtkunkel