Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix for crash with ws_distance in parallel #117

Merged

Conversation

giovannipizzi
Copy link
Member

Problem: wannier_centres was not broadcast, now it is
This fixes #104

@giovannipizzi giovannipizzi requested a review from jryates March 28, 2017 23:02
@giovannipizzi
Copy link
Member Author

This is not yet enough... temporarily closing this issue to investigate more

of the ws_distance routine (simplified, and now I return directly
the integer values I'm interested about, rather than going through
floats and trying then to get back the integers at the end).
@giovannipizzi giovannipizzi reopened this Mar 29, 2017
@mostofi mostofi self-requested a review March 29, 2017 16:23
Copy link
Member

@jryates jryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me

@mostofi mostofi merged commit 7ec1f09 into wannier-developers:develop Mar 29, 2017
@giovannipizzi giovannipizzi deleted the fix_geninterp_wsdistance_bug branch March 31, 2017 12:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_si_geninterp_wsdistance: SIGSEGV
3 participants