Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid subtracting num_exclude_bands twice in library mode #170

Merged

Conversation

rmargine
Copy link
Contributor

Fixing the problem in library mode where num_exclude_bands was subtracted twice.
This was introduced in #19 trying to fix the fact num_bands wasn't defined in library mode.
The solution of #19 was to subtract num_exclude_bands in param_read, but param_read is run twice (in wannier_setup and wannier_run). Now, we set num_bands to the correct value (already subtracted) in wannier_lib.f90, but we do it before calling param_read, so this should be a fix both to the current problem and to the original problem of #19.

@giovannipizzi giovannipizzi self-requested a review March 21, 2018 15:12
@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #170 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
- Coverage    57.41%   57.41%   -0.01%     
===========================================
  Files           27       27              
  Lines        15573    15572       -1     
===========================================
- Hits          8942     8941       -1     
  Misses        6631     6631
Impacted Files Coverage Δ
src/parameters.F90 77.54% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f143f...7a8dc64. Read the comment docs.

@giovannipizzi giovannipizzi merged commit efe9053 into wannier-developers:develop Mar 21, 2018
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
…ands_library

Avoid subtracting num_exclude_bands twice in library mode
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants