Fix disentanglement bug after introduction of parallel routines #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error was occurring only with specific band structures where only some kpoints had more bands than WFs - I think this is why we didn't notice it before
Codecov Report
@@ Coverage Diff @@
## develop #193 +/- ##
===========================================
- Coverage 57.99% 57.99% -0.01%
===========================================
Files 27 27
Lines 16052 16051 -1
===========================================
- Hits 9310 9309 -1
Misses 6742 6742
Continue to review full report at Codecov.
|
jryates
approved these changes
Jul 24, 2018
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
…disentanglement_bug Fix disentanglement bug after introduction of parallel routines
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #192 (see discussion there for details of the bug).
This PR also adds a test to verify the problem is solved.