Partially solves #229 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #235 +/- ##
========================================
Coverage 62.01% 62.01%
========================================
Files 29 29
Lines 17161 17161
========================================
Hits 10643 10643
Misses 6518 6518
Continue to review full report at Codecov.
|
giovannipizzi
requested changes
Jan 30, 2019
There was a problem hiding this comment.
As there will probably be more changes to the documentation and tutorial, maybe we shouldn't add a precompiled PDF yet? See also my comment in #229 that actually suggests not to add the PDF at all in the repo.
| @@ -55,8 +55,12 @@ example21: Gallium Arsenide - Symmetry-adapted Wannier functions | |||
|
|
|||
| example22: Copper - Symmetry-adapted Wannier functions | |||
|
|
|||
| example23 : Silicon - G0W0 bands structure interpolation | |||
| example23: Silicon - G0W0 bands structure interpolation | |||
VVitale
force-pushed
the
changes_for_229
branch
from
729978e to
f10f3c8
Compare
VVitale
force-pushed
the
changes_for_229
branch
from
f10f3c8 to
fde7175
Compare
giovannipizzi
approved these changes
Jan 30, 2019
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from the small changes to the version number and date in various files, I have added some comments in the Introduction section of the User Guide to reflect the changes from the last release. In particular, I have added a paragraph in the subsection Getting Help which states that an alternative way to contact us and receive help is by raising an issue on the GitHub repository.