Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix test with rack >= 3 and test with Ruby > 3.0 #213

Merged
merged 4 commits into from
Sep 7, 2024

Conversation

masterT
Copy link
Contributor

@masterT masterT commented Mar 1, 2024

Since rack 3.0.0, Rack::Session was extracted to a separate gem (see: rack/rack#1805).

Add the rack-session gem to the Gemfile and require it in the test.

Add more Ruby versions (3.1, 3.2, 3.3) to the CI.

Update GitHub action actions/checkout to v4.

masterT added 4 commits March 1, 2024 15:52
Since rack 3.0.0, `Rack::Session` was extracted to a separate gem.
See: rack/rack#1805

Add the `rack-session` gem to the Gemfile and require it in the test.
@doolin
Copy link
Contributor

doolin commented Sep 7, 2024

I like it, what does it need for getting merged and versioning the gem?

@jsmestad jsmestad merged commit 9445064 into wardencommunity:master Sep 7, 2024
7 checks passed
@jsmestad
Copy link
Collaborator

jsmestad commented Sep 7, 2024

Thanks I've pulled this in

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants