Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for watchpack options #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

no-mae
Copy link

@no-mae no-mae commented Oct 25, 2021

Support for watchpack options.
I'll set it to { poll: true } to run hot reload in my env.

@EndilWayfare
Copy link

This is a fantastic addition! I was about to submit a pull request of my own that just forwarded the watchOptions on the compiler itself, if set, because they weren't otherwise user set-able.

I like this solution better, because it's more thorough and configurable. I would suggest, though, defaulting to the compiler's watchOptions for options not set on the plugin, so the user's project-wide watch settings are DRY unless manually necessary.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants