move Wasp/Generator/Node/Version to Wasp/Node/Version
#1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martinsos
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Looking good! Feel free to merge @craigmc08 .
We don't do merge commits unless necessary, instaed we usually squash all commits into one and rebase that onto main. Sometimes we don't squash them all but just some, if we want to preserve some of the commits.
Easiest thing to do therefore is to just click on squash and merge.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
Wasp/Generator/Node/VersiontoWasp/Node/Versionsince now modules outside of Generator depend on Node's version.As discussed in https://github.com/wasp-lang/wasp/pull/1210/files#r1206824035.