Fixes oAuth redirect behaviour in development #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
Martinsos
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
@infomiho great! I get that this is tricky hm, but seems like good fix for now.
Could you maybe just add a comment in the code, desribing what you commented in the PR (that we did it because of StrictMode and don't know of a better solution at the moment)?
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1272
Based on https://stackoverflow.com/questions/73732474/handling-oauth-with-react-18-useeffect-hook-running-twice
Fixing it this way is not recommended by the docs, but they don't offer any alternatives for this particular use case (oauth redirect page): https://react.dev/learn/synchronizing-with-effects#how-to-handle-the-effect-firing-twice-in-development