chore(deps): update dependency ftp-srv to 4.4.0 [security] - autoclosed #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.1.0
->4.4.0
GitHub Vulnerability Alerts
CVE-2020-15152
Background
The FTP protocol creates two connections, one for commands and one for transferring data.
This second data connection can be created in two ways, on the server by sending the PASV command, or on the client by sending the PORT command.
The PORT command sends the IP and port for the server to connect to the client with.
Issue
Since the client can send an arbitrary IP with the PORT command, this can be used to cause the server to make a connection elsewhere.
Patches
Deprecation notices have been published for older versions.
Workarounds
Blacklisting the FTP Command
PORT
will prevent the server from exposing this behaviour through active connections until a fix is applied.References
https://www.npmjs.com/advisories/1445
Credits
Thank you to;
@trs for fixing it
@andreeleuterio for reporting it to us for an anonymous user (Vincent) through the NPM platform
@quiquelhappy for bringing it to our attention after it slipped through the cracks during Christmas
For more information
If you have any questions or comments about this advisory:
CVE-2020-26299
Impact
Clients of FTP servers utilizing
ftp-srv
hosted on Windows machines can escape the FTP user's defined root folder using the expected FTP commands, for example,CWD
andUPDR
.Background
When windows separators exist within the path (
\
),path.resolve
leaves the upper pointers intact and allows the user to move beyond the root folder defined for that user. We did not take that into account when creating the path resolve function.Patches
None at the moment.
Workarounds
There are no workarounds for windows servers. Hosting the server on a different OS mitigates the issue.
References
Issues:
QuorumDMS/ftp-srv#167
QuorumDMS/ftp-srv#225
For more information
If you have any questions or comments about this advisory:
Open an issue at https://github.com/autovance/ftp-srv.
Please email us directly; security@autovance.com.
Renovate configuration
📅 Schedule: "" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.