Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SRAD Altimeter #91

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

SRAD Altimeter #91

wants to merge 36 commits into from

Conversation

AshTheEngiqueer
Copy link
Contributor

Currently a schematic review only.

@KavinSatheeskumar
Copy link
Contributor

First round of comments, going to get food and will keep roasting

  • Termination Resistor for GPS CAN Transceiver
  • Talk to the GPS via Serial (or something else) rather than CAN, since having two independent CAN buses on one board has been a known pain point for Payload 2022
  • can't look at the web-bench TI link because I cannot login
  • Add no-connect to unconnected pin on the STM
  • Looking at the TLP3543A here, (according to Ash), the direction of current of the two mosfets must be opposite, however there is nothing on the schematic to distinguish that. (IE, the little diodes inside the symbol both point in the same direction and the part numbers are the same)
    image
  • please add data sheet to all IC's used in your schematic

@KavinSatheeskumar
Copy link
Contributor

More comments

  • This should be 3V3
    image
  • Where do GPSCANH and GPSCANL
  • This dosen't match the label coming into the sheet (from the outside its PYRO, on the inside its +PYRO)
    image
  • Connect to Ground
    image

@Armaan-Sengupta
Copy link
Contributor

Armaan-Sengupta commented Jan 9, 2025

  1. Add another filter capacitor to 3v3 according to datasheet (same for the GPS one)
    image
    image
  2. VDD pin should be connected to 5V for GPS CAN
    image
  3. Enable should not be floating tie it to ground
    image

Unfortunately i'll need to be given some context about how the pyros work before I can review those parts, but otherwise lgtm.

Copy link
Contributor

@Armaan-Sengupta Armaan-Sengupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshTheEngiqueer
Copy link
Contributor Author

AshTheEngiqueer commented Jan 9, 2025

@Armaan-Sengupta

  1. sorry, wdym by another filter capacitor according to the datasheet? the image you've suggested says I need one on VDD and VIO?
  2. I'm not convinced it should be, the GPS module takes 3V3 in so that's my justification behind running the altimeter/gps CAN on 3V3
  3. datasheet says it doesnt matter if its pulled high or left floating, but if its pulled to GND then it'll disable the buck :P

@Armaan-Sengupta
Copy link
Contributor

  1. Yea to add a 0.1uF cap to VIO (3v3)
  2. So the VIO should be 3V3 then right? But the actual MCP needs 5v (page 9) so VDD should be 5V
    image
  3. Ah yes I read the min max voltage backwards but I see the note on page 3 now. Also it has an internal pullup which I did not see before, yea chilling what u did makes sense.

@Rio6
Copy link
Contributor

Rio6 commented Jan 10, 2025

  1. D1 is 1A max, is that enough? 圖片
  2. Is this huge capacitor neccessary? With LiPo instead of 9V I'd imagine it can source a lot more current on 12V side, and keeping 3V happy.
    圖片
  3. These fuses can probably be bigger, what is the limiting factor here?
    圖片
  4. 500ohm gives (3.3V - 1.8V) / 500 = 3mA which is just above the trigger current. The recommended forward current is 10mA from datasheet.
    圖片
  5. Fix DRC (both errors and warnings), even if most of them are harmless they can bury actual errors

@AshTheEngiqueer
Copy link
Contributor Author

  1. This was the diode sourced by Jason so idk, I'll look
  2. Yup, good point, will think about this one more
  3. Limiting factor is we'd like the fuse to break if the ematches are shorted (but this is kind of fake now that we have the 4R resistors I think? mag switch can take 20A for 5 seconds and 4R limits us to ~3A in case ematches are shorted)
  4. Good catch, I forgot to account for the SSR forward voltage drop.
  5. Not sure how to fix a bunch of the warnings? stuff like "input power pin not driven by output power pin", or "symbol pin or wire end off connection grid". those I've ignored, added NC symbols to all unused pins.

@Rio6
Copy link
Contributor

Rio6 commented Jan 10, 2025

For "wire end off grid" you can right click and ignore all that type of error.

For "power pin not driven" there's a power flag component you can connect to the power nets like this
圖片

@zx100x100
Copy link
Member

  1. pedantic, but I would recommend putting the current sensing math on the schematic so it is obvious the max current for each channel. I also don't love separating the shunt from the sensing amp on the schematic since it might be easier to forget that they need to be routed very close together.
    image

  2. What is your math for these pull-ups and sense circuits? what do you expect to see on the sense line across the different operating conditions? (IDK if it does what you want it to do)
    image

  3. what is this supposed to do? it looks like current sensing, but the E-matches have a non-linear, variable resistance, so this doesn't work for current sensing since you don't know R
    image

  4. this part number is a 6 pin connector but the schematic is 2 pins! based on the spreadsheet 6 pins is correct, in which case I would recommend redundant connections for + and - so that we can harness parallel E-matches separately if desired.
    image

5.As discussed documentation really needs updates, particularly to requirements, and description of system architecture

Copy link
Member

@BluCodeGH BluCodeGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Your labels for the programming pins are wrong. When only 2 pins are connecting we're using SWD not JTAG mode
  2. Why do you have boot0 selection and a reset jumper? IIRC we've never used either, and camera worked just fine without either.
  3. Why do you have an external oscillator? Again camera worked without it, the internal one is usually fine?
  4. Resize the LED resistors for 3.3V
  5. There are weird doubled up DNP resistors on the pololu sheet?
  6. You don't need to connect to the pololu addr pin, save yourself the hassle and 1x1 connector.
  7. Also you should inject 3.3V direct to VDD on the pololu not via VIN
  8. It would be nice to use the 4R resistor as a pyro current sense measurement for real, probably via a voltage divider of the low side into the STM?
  9. CANH/CANL test points are kinda silly cause there's a connector right there
  10. I'd move the main/drogue testpoints to the pyro sheet
  11. I'd also move the current sense testpoints to the power sheet
  12. The INA4180 is kinda hard to lay out, I'd suggest 2x INA2180, one on the power sheet and one on the main sheet
  13. The 5V LDO max input voltage is 12V, but lipos go to 12.6
  14. The 3.3V buck has a soft start time of 2ms which isnt enough to charge the capacitor given its 3A limit, so we're going to be overcurrenting it. I really think you should reduce the requirements on that capacitor to make it a more reasonable size, eg maybe you only need 20ms and the STM32 can handle going to 2V or something, idk. Otherwise you need a buck with configurable soft start.
  15. F1 has the wrong footprint, also are there smaller options? Its kinda big
  16. L1 schematic value should be the part number, not the size
  17. Same for C31
  18. The ferrite bead is 0603, choose an 0805 one?
  19. The SDMMC app note link is missing
  20. I glanced at it but pls try to configure all your pins in STM32cube and make sure its happy before ordering
  21. Like Zach mentioned you should change the pyro connectors, I think you should have a single M80 harwin with main + drogue in the same pinouy as RA.

@AshTheEngiqueer
Copy link
Contributor Author

AshTheEngiqueer commented Jan 21, 2025

@BluCodeGH
2. Processor had both, I'll ask Joe if either was useful.
3. I know we use external oscillators for the PICs and processor also used an external oscillator. Didn't realize camera was fine without.
14. Yeah, I'm kind of lost on this one ngl - not sure how to find a 'reasonable' time for a brief battery disconnect caused by vibration. I've been using Vmin equal to min operating voltage of the STM32 (1.7V).
15. Not really? if we want a PTC with a hold current of 7.5A, max voltage >= 12.6V, and SMD then this is our only option. I suppose THT might be better, I'll do some looking
19. No it's not? its hyperlinked
20. Yup for sure, I spent like 3 hours going through the datasheet but thats just a better idea

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants