Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rocket power board #93

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Rocket power board #93

wants to merge 14 commits into from

Conversation

Pdada1
Copy link

@Pdada1 Pdada1 commented Nov 26, 2024

No description provided.

@AshTheEngiqueer
Copy link
Contributor

Assuming this is good to review despite the PR still being marked as a draft?

  1. There's a lot of stuff on the root page, and the subsheets are basically empty. I think you could have your buck, battery charge circuitry, and current sensing on the same sheet? In general there's some messy stuff that would benefit from being tidied up, both for aesthetics but also readability.
  2. You should note the fuse current, and on that note I think 6.3A is too high? my napkin calculation says that 4A is sufficient - 2A max through the gecko on both the 5V and 12V lines, and the battery current draw due to the 5V is at most (2A * (5V/12V) * 1/e) = 0.92A (assuming an efficiency of 90%).
  3. On the 5V enable, I'm not sure why you're using the Drain-Source voltage to size R14/15? Should you not be using the Gate-Source Threshold voltage to calculate the divider such that V(HIGH) across the divider gives a voltage just above VGSth?
  4. Your P-MOSFET has an insufficient Continuous Body Diode Forward Current (1.5A) - from the buck and the gecko we can output up to 2A, is there a reason we're limiting it here?
  5. Is there a reason you don't have a low-pass RC filter on the INA2180? You should also make a note of the gain of the INA.
  6. Rather than add a solder jumper to the CAN termination resistor, you could mark it as DNP and only add it if you do actually need it.

@Pdada1 Pdada1 marked this pull request as ready for review January 15, 2025 00:15
@ManavToor
Copy link
Contributor

Please organize your schematic better, it is very difficult to read.

@Pdada1 Pdada1 requested a review from ManavToor January 29, 2025 23:51
Copy link
Contributor

@AshTheEngiqueer AshTheEngiqueer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Sorry I wasn't clear, I meant that you should put a differential low pass filter on the inputs to the INA.
    nvm im trolling, yes the low pass filter should be right at the ADC pin
  2. How did you size the fuse? What math/current draw/data has been referenced?
  3. Current sense resistors not sized still?
  4. Some of your footprint links are broken - There's a footprint from tutorial board, as well as several from other projects and some from folders in your downloads folder. These should all be in the project specific footprint library, and should be referenced with a relative filepath, rather than an absolute filepath.

@AshTheEngiqueer
Copy link
Contributor

Still some weird schematic stuff - ex. lipo voltage from power subsheet goes to VCC on main sheet which only connects to 12V sense in on power subsheet?

  1. Why is R8 so small? if 2A max this gives you a V range from 0 to 2V - try to use most of the voltage range (for the PIC, 0-5V)
  2. I was thinking about this more - we also want current sense for the 12V rail to rocket, and battery charging current
  3. Not sure how I missed this one, but the buck converter wants 3 1uF input capacitors.
    image

Layout:
4. C13 and 14 are getting kind of far from the 12V input - probably best to do a 2x2 array of capacitors, if that makes sense?
5. You can move R1 and R2 closer to the buck
If you haven't already, read 9.4 of the buck datasheet, and also AN-1149

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants