-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rocket power board #93
base: master
Are you sure you want to change the base?
Conversation
Assuming this is good to review despite the PR still being marked as a draft?
|
Please organize your schematic better, it is very difficult to read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Sorry I wasn't clear, I meant that you should put a differential low pass filter on the inputs to the INA.
nvm im trolling, yes the low pass filter should be right at the ADC pin - How did you size the fuse? What math/current draw/data has been referenced?
- Current sense resistors not sized still?
- Some of your footprint links are broken - There's a footprint from tutorial board, as well as several from other projects and some from folders in your downloads folder. These should all be in the project specific footprint library, and should be referenced with a relative filepath, rather than an absolute filepath.
Still some weird schematic stuff - ex. lipo voltage from power subsheet goes to VCC on main sheet which only connects to 12V sense in on power subsheet?
Layout: |
No description provided.