Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix on_close propogation + bump websocket-client #817

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wwwehr
Copy link

@wwwehr wwwehr commented Apr 17, 2022

Satisfies #810

Also, the websocket client class sends messages to the on_close handler that do not match the signature that result in an error:

from callback <bound method SynthesizeListener.on_close of
 <ibm_watson.websocket.synthesize_listener.SynthesizeListener object at
 0x123456789>>: on_close() takes 2 positional arguments but 4 were given

This PR fixes this issue.

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2022

CLA assistant check
All committers have signed the CLA.

@wwwehr
Copy link
Author

wwwehr commented Jun 24, 2022

@jeff-arn @kevinkowa @Hsaylor

Hoping to get this reviewed and merged. I thought I followed the contributors notes - please advise if I need to do anything else!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants