Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add '-v, --version' and '--dry-run' CLI options #12

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

trentm
Copy link
Collaborator

@trentm trentm commented Dec 11, 2023

When combined with --verbose, the '-n' dry-run option
provides a useful quick summary of the install/execution
work that would be done. This is helpful for debugging
slow tav ... runs for version ranges that cover too many
versions.

Update: Changed option names to -v, --version and --dry-run.

Combined with --verbose, it provides a useful quick
summary of the install/execution work that would be
done.
@trentm
Copy link
Collaborator Author

trentm commented Dec 11, 2023

@watson Are you interested in reviewing this change?

(I use this tool heavily with https://github.com/elastic/apm-agent-nodejs and more recently with https://github.com/open-telemetry/opentelemetry-js-contrib. I'd be happy to help with maintenance if you like.)

Copy link
Owner

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions! Just a few nits

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@trentm trentm changed the title feat: add '--version' and '-n' (dry-run) CLI options feat: add '-v, --version' and '--dry-run' CLI options Dec 12, 2023
@watson watson merged commit f539be4 into watson:master Dec 13, 2023
2 checks passed
@trentm trentm deleted the tm-version-dry-run-opts branch December 14, 2023 17:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants