-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Execute in Edit Mode #208
Comments
Yeah, probably. I did some experiments where i slap [ExecuteInEditMode] and set HideFlags to DontSave on the ocean components/generated GOs and it gets a bunch of the way there, but there might be a fair bit of fixup required to get all the state figured out to work in edit mode and be robust etc. I'll post back if i make progress. |
Sounds great! I have been trying to work it out. This has been a most requested feature by our team do I have been trying to figure outs ways to get it working. Also, I have been trying to get Bow Wakes without having the objects move. Let me know if you have any pointers for that as well. |
It does the overall thing, but its not heavily tested, and there are resources leaking here and there and some other lifetime issues.
I put a bit more time into it and was surprised to see something kinda working. There are resource lifetime issues and usually some errors creep into the log (at which point i'm currently reopening the scene) but the basics seem to be there. I'd be very interested if it already works with the Timeline and what kinds of functional tradeoffs it currently has, if you'd be in a position to grab it and try it with your project? It's in the branch feature/ocean-in-edit-mode |
Perhaps open a separate issue for bow wakes if you dont mind so we dont mix issues together. If you could outline what you're doing/what you want a bit more that would be useful. |
That seems to be working better than what I thought it would. Yes. I will create a separate Issue for the Bow Wake feature, |
@SilverbackKarthik are you working on this at the moment, I'm considering taking this on unless you are happy completing this. 🙂 If you've done any further work so far I am happy to take things on from there. |
@moosichu Yes, I am using it in a project and trying to fix few optimization bugs. But, have not had the time to test them through. So, If you are starting to work on this, It's all yours. I would like to get updates on your work as well. So, I guess thread could be a place to share the info. |
@moosichu and I are focusing on other things in the short term so we're not pushing this forwards right now, but will post if we get back to it. |
Hi, sorry for the slow reply. I will get back to this at some point, just have a few higher priority things atm and it's been a busy couple weeks. The work that has been done so far (mostly by Huw) is in this branch, which I have mostly brought up-to-date with master. It still needs a fair bit of work though. |
Merged into BIRP (master branch), will make its way into URP/HDRP in 4.3 |
Can we have the Ocean be generated in Edit Mode similar to Unity Particle System?
The reason behind this is that the project we are using this for is based on Unity Timeline and we would like to scrub the timeline in edit mode and see it with the waves. Even a low poly mesh based render would help visualize it.
I am making using of the Time Provider with the Timeline time to scrub in runtime mode now.
The text was updated successfully, but these errors were encountered: