Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug]: term:localshellopts does not work for Powershell #1522

Closed
3 tasks
neradp opened this issue Dec 15, 2024 · 3 comments · Fixed by #1535
Closed
3 tasks

[Bug]: term:localshellopts does not work for Powershell #1522

neradp opened this issue Dec 15, 2024 · 3 comments · Fixed by #1535
Labels
bug Something isn't working triage Needs triage

Comments

@neradp
Copy link

neradp commented Dec 15, 2024

Current Behavior

When I set "term:localshellopts": "-nologo" for "term:localshellpath": "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" it does nothing. Powershell runs as normal.

Expected Behavior

Powershell without "logo".

Steps To Reproduce

When I set "term:localshellopts": "-nologo" for "term:localshellpath": "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" it does nothing. Powershell runs as normal.

Wave Version

0.10.1

Platform

Windows

OS Version/Distribution

Windows 11 24H2

Architecture

x64

Anything else?

No response

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@neradp neradp added bug Something isn't working triage Needs triage labels Dec 15, 2024
@esimkowitz
Copy link
Member

Just checking, are you running on arm or was that a typo?

@esimkowitz esimkowitz changed the title [Bug]: term:localshellopts does not work [Bug]: term:localshellopts does not work for Powershell Dec 15, 2024
@neradp
Copy link
Author

neradp commented Dec 15, 2024

sorry it was a typo... amd64 👯

@esimkowitz
Copy link
Member

esimkowitz commented Dec 17, 2024

The correct config format for this is:

{
  ...
  "term:localshellopts": ["-NoLogo"]
}

I am going to close this as not planned, since this is by design, but I'll add a note to the docs

esimkowitz added a commit that referenced this issue Dec 17, 2024
adds example to avoid confusion and resolve #1522
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working triage Needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants