Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Self-Service Fork Request: PR Workflow #20

Merged
merged 67 commits into from
Oct 13, 2022
Merged

Conversation

lelia
Copy link
Collaborator

@lelia lelia commented Oct 10, 2022

Description

With #14 paving the path for semi-automated PR templates, this PR aims to fully productionize the POC introduced in #8 in order to make the Fork a repository PR template fully self-service for Wayfair developers. This PR also depends on the forkUrl output introduced in forker v0.0.6 (via wayfair-incubator/forker#230).

In order to test the functionality of this automated workflow, I created several 'dummy' request YAML files to ensure that the validation checks and other parsing logic worked correctly, hence the many PR approvals and fork creation comments you'll notice were left by lhasa-ospo.

For reviewing purposes, it may be helpful to follow along in the markdown-rendered README for forking a repository (this is also linked to in the main README), to make sure the instructions are clear and easy to follow. If you'd like to test out the workflow yourself, I believe you may be able to do so by filing a PR against this branch (self-service-fork-worfklow) and following the aforementioned README instructions.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

🚨 Not the PR template you wanted? Click the Preview tab above, then navigate back to the OSPO Automation PR Menu!

@lhasa-ospo
Copy link
Contributor

🎉 All set @lelia! Here's your fork: https://github.com/wayfair-contribs/typescript-action

@lhasa-ospo
Copy link
Contributor

🚨 Hey @lelia, looks like there was an issue processing your fork request! Please ensure you've committed a properly-formatted YAML (.yml) file to the requests/fork/ directory.

@lelia
Copy link
Collaborator Author

lelia commented Oct 12, 2022

🚨 Hey @lelia, looks like there was an issue processing your fork request! Please ensure you've committed a properly-formatted YAML (.yml) file to the requests/fork/ directory.

Note that the fork workflow is going to fail on any new commits since my branch no longer has a .yml file under requests/fork, this shouldn't prevent the PR from being merge-able, though.

Co-authored-by: Gary White Jr. <7660110+GaryPWhite@users.noreply.github.com>
@wayfair wayfair deleted a comment from lhasa-ospo Oct 13, 2022
@lelia lelia added automerge and removed automerge labels Oct 13, 2022
@wayfair wayfair deleted a comment from lhasa-ospo Oct 13, 2022
@lhasa-ospo
Copy link
Contributor

🎉 All set @lelia! Here's your fork: https://github.com/wayfair-contribs/filters

@lelia lelia merged commit a20c9ae into main Oct 13, 2022
@lelia lelia deleted the self-service-fork-workflow branch October 13, 2022 18:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants