Updated GraphQL syntax #7444
Updated GraphQL syntax #7444
Conversation
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: GraphQL Syntax
Results help
Packages added:
- GraphQL Syntax
Processing package "GraphQL Syntax"
- WARNING: The "platforms" key may be omitted instead of specifying all platform
- WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: GraphQL Syntax
Results help
Packages added:
- GraphQL Syntax
Processing package "GraphQL Syntax"
- WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
|
About |
|
Would the original author be interested in a new maintainer for the package? If possible, it would be better to maintain one package in PC. |
|
@fermads ping |
Thom1729
added
the
stale
|
I've tried to talk to the owner (
dncrews/GraphQL-SublimeText3#6). I do agree one
package would be better and I also don't want to maintain it. I've solved
my problem (and my team's) by linking to my fork for now. If the current
owner replies, I can try to find another owner (or convince him to merge +
update in PC)
…On Sat, Mar 23, 2019 at 11:20 AM Thomas Smith ***@***.***> wrote:
@fermads <https://github.com/fermads> ping
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7444 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAO0Q6Wd3ZNqDKKid2cF-UK59GmNLKaHks5vZnBRgaJpZM4aQR-i>
.
|
|
Since @dncrews seems to be AWOL, I approve of replacing the package listing of the current GraphQL package with your fork (or the ST3 version at least). You may also choose to rename the package, but I highly doubt this is practical here. We grant @dncrews a two week period to object the replacement, otherwise you may proceed with it. @dncrews, if you don't want your package to be replaced, please comment. |
|
I don't know how I didn't see that until now, but I've merged his PR. I would've handed over maintenance just because I feel bad for missing this for 7 months, but his comment said he didn't want to maintain it. |
|
Great, I'm closing this then because I believe the concern to be addressed. @dncrews don't forget to push a new tag with the changes, otherwise Package Control won't see this update. |
|
Done, thank you for the reminder. |
|
Thank you!
…On Mon, Jun 17, 2019 at 9:00 AM Dan Crews ***@***.***> wrote:
Done, thank you for the reminder.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7444?email_source=notifications&email_token=AAB3IQ3OR6ENA3373MR3TWTP26YKNA5CNFSM4GSBD6RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3USAQ#issuecomment-502745346>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB3IQ6OK5CM7FUFKXIO5PTP26YKNANCNFSM4GSBD6RA>
.
|
Forked from dncrews/GraphQL-SublimeText3 this package has support for newer GraphQL syntax (triple quotes / block strings). I've created a PR on the original project ~ 2 months ago but seems like the project is not being maintained.
As per GraphQL RFC and its implementation, doc strings are here since 2017 and are the preferred (and only) way to add documentation to GraphQL.
Without this change, using bloc strings breaks the syntax highlighting on Sublime.