Fix copy / paste behavior when using Firefox or Edge [Clipboard / Selection API] (#51) #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anlambert
changed the title
anlambert
force-pushed
the
fix-copy-paste-issue-clipboard-api
branch
4 times, most recently
from
32de479 to
cfd1a7e
Compare
anlambert
force-pushed
the
fix-copy-paste-issue-clipboard-api
branch
from
cfd1a7e to
0175fd4
Compare
wcoder
approved these changes
Mar 17, 2019
swhmirror
pushed a commit
to SoftwareHeritage/swh-web
that referenced
this pull request
Mar 27, 2019
See wcoder/highlightjs-line-numbers.js#62 for more details.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another attempt to fix #51 but using an approach different from the one in #60 (as pointed here).
Here, the copy / paste issue when using Firefox or Edge is resolved using the Clipboard API and the Selection API.
Apart a workaround needed for Microsoft Edge, I find that solution much more elegant and less complicated than the first one I have already submitted (#60). Also, there is no changes in the HTML layout and considering the APIs mentioned above seem widely supported, I think this solution should be preferred.
CSS selectors improvements as introduced in #60 are also still part of that new PR.