Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Python 3.x support #26

Closed
wearpants opened this issue May 7, 2013 · 10 comments · Fixed by #34
Closed

Python 3.x support #26

wearpants opened this issue May 7, 2013 · 10 comments · Fixed by #34
Milestone

Comments

@wearpants
Copy link
Owner

Make sure things work nice with 3.x, use 2to3, etc.

@ralphbean
Copy link

This would be tight. You could also use six instead of 2to3.

@wearpants
Copy link
Owner Author

I've had reports that things work ok after running 2to3 on the source.

@msabramo
Copy link
Contributor

See PR #34 -- that adds Python 3 support using six, no use_2to3 required.

@msabramo
Copy link
Contributor

PR #34 merged. This can probably be closed once a few folks verify that it works.

@wearpants
Copy link
Owner Author

yeah, some of the logging_compat stuff was probably borked under 2.x to begin with

@msabramo
Copy link
Contributor

@msabramo
Copy link
Contributor

OK, next logical step -- time perhaps for a release to PyPI? https://pypi.python.org/pypi/Twiggy

@wearpants
Copy link
Owner Author

mmm, there's some non-working stuff in master (logging_compat, mainly) -
there's a note in the README.
A 0.4.6 release supporting 3.x & pypy would need to come from the maint-0.4
branch (which either needs yr merged changes or the same 2to3 + six
treatment)

There's more work before a 0.5 release from master:
https://github.com/wearpants/twiggy/issues?milestone=3&page=1&state=open
Mainly, this is finishing/cleaning up the bidirectional support for stdlib
logging in twiggy.logging_compat The enhancements could be pushed back
of course.

I haven't worked on this code in quite a while as you can see, thanks for
looking at it again.

On Wed, Mar 26, 2014 at 4:40 PM, Marc Abramowitz
notifications@github.heygears.comwrote:

OK, next logical step -- time perhaps for a release to PyPI?
https://pypi.python.org/pypi/Twiggy

Reply to this email directly or view it on GitHubhttps://github.com//issues/26#issuecomment-38743570
.

Peter Fein | wearpants.org | @wearpants

I read email at the start and end of each day. IM if urgent.

@canoon
Copy link

canoon commented Apr 8, 2014

Seems there's an issue with the importing?

[root@arch-work ~]# pip show twiggy
---
Name: Twiggy
Version: 0.4.5
Location: /usr/lib/python3.4/site-packages
Requires: 
[root@arch-work ~]# python
Python 3.4.0 (default, Mar 17 2014, 23:20:09) 
[GCC 4.8.2 20140206 (prerelease)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import twiggy
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.4/site-packages/twiggy/__init__.py", line 7, in <module>
   import filters
ImportError: No module named 'filters'

@canoon
Copy link

canoon commented Apr 8, 2014

Sorry, ignore my derp. pip doesn't have the same version as git.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants