This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Fix MASTER_IP definition in kubeadm README #741

Merged

stealthybox merged 1 commit into weaveworks:master from EmeraldShift:master

Dec 7, 2020

Contributor

EmeraldShift commented Dec 1, 2020

Resolves #740. Tested by spawning a VM with name master-0, running the command, and reading $MASTER_IP.

ignite run ... --name master-0
export MASTER_IP=$(ignite inspect vm master-0 | jq -r ".status.network.ipAddresses[0]")
echo $MASTER_IP # Prints a valid IP address.


          Fix MASTER_IP definition in kubeadm README

e11f82b

EmeraldShift requested review from chanwit, darkowlzz, luxas, stealthybox and twelho as code owners

December 1, 2020 23:43

Contributor

stealthybox commented Dec 7, 2020

Just tried this edit out a little bit -- thanks for the fix :)

stealthybox merged commit 51c762f into weaveworks:master

stealthybox added the documentation/better-examples label

# for free to subscribe to this conversation on GitHub. Already have an account? #.

Reviewers

chanwit Awaiting requested review from chanwit

darkowlzz Awaiting requested review from darkowlzz

luxas Awaiting requested review from luxas

stealthybox Awaiting requested review from stealthybox

twelho Awaiting requested review from twelho

Labels

documentation/better-examples