This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
runtime: Handle error when container not found #809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing or stopping a VM, if the container runtime returns error
because it can't find the associated VM container, the remove fails.
With this change, ignite will checks if the container runtime error is
about container not found and return without any error, no-op, letting
the operation succeed.
Before:
After(containerd):
Docker:
NOTE: This change avoids the usage of
ifFound()
in containred/client.go to keep the changes minimal for now. UsingifFound()
results in a lot of code restructuring due to named error return, easily resulting in shadowed error related issues. A proper refactoring could be done separately.Fixes #751